[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1G
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6) |
Date: |
Tue, 26 Nov 2013 10:04:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 25/11/2013 22:05, Michael S. Tsirkin ha scritto:
>> > Signed-off-by: Marcelo Tosatti <address@hidden>
>> > [Reorganize code, keep same logic. - Paolo]
>> > Signed-off-by: Paolo Bonzini <address@hidden>
> BTW how about a unit-test for this?
> Can be something along the lines of the acpi tests:
> run BIOS, probe what it reported.
>
No, it can't because the change is not guest visible. It is not enabled
for machine types <=1.8 due to migration compatibility (the migration
stream uses offsets within the RAM block, and these change), but there
is no difference from the guest point of view.
Paolo