Re: [Qemu-devel] [PATCH] fix compilation on FreeBSD for mac_*world.c

[Andreas Färber]

Am 28.11.2013 22:33, schrieb Andreas Tobler:
> Hello,
> 
> On 09.11.13 00:15, Andreas Tobler wrote:
>> Hello,
>>
>> the attached patch fixes compilation on FreeBSD for
>> hw/ppc/mac_new/oldworld.c on FreeBSD.
>>
>> The affected function is present in machine/param.h on FreeBSD:
>>
>> #define round_page(x)   ((((unsigned long)(x)) + PAGE_MASK) & ~(PAGE_MASK))
>>
>> To make it compile on FreeBSD I'd like to propose the below patch which
>> is in use since a longer time on the ports tree (FreeBSD) and in my
>> personal git tree.
>>
>> Thanks,
>>
>> Andreas
>>
>> Signed-off-by: Andreas Tobler <address@hidden>
>>
> 
> This time qemu-devel list included.
> 
> Ping?

I remember writing a patch to fix this or a very similar issue in those
files by adding a prefix for the local version. Have you checked the
list archives or git log?

Apart from that, the Sob is broken and we prefer patches git-send-email
style with a ready-to-apply commit message:
http://wiki.qemu.org/Contribute/SubmitAPatch

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg