Re: [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX descriptor match mode flags

[Peter Maydell]

On 2 December 2013 07:12, Peter Crosthwaite
<address@hidden> wrote:
> The various Rx packet address matching mode flags were not being set in
> the rx descriptor. Implement.

> -#define GEM_RX_REJECT  1
> -#define GEM_RX_ACCEPT  0
> +#define GEM_RX_REJECT                   (-1)
> +#define GEM_RX_PROM_ACCEPT              (-2)
> +#define GEM_RX_BROADCAST_ACCEPT         (-3)
> +#define GEM_RX_MULTICAST_HASH_ACCEPT    (-4)
> +#define GEM_RX_UNICAST_HASH_ACCEPT      (-5)
> +
> +#define GEM_RX_SAR_ACCEPT               0

> @@ -527,9 +559,6 @@ static unsigned calc_mac_hash(const uint8_t *mac)
>  /*
>   * gem_mac_address_filter:
>   * Accept or reject this destination address?
> - * Returns:
> - * GEM_RX_REJECT: reject
> - * GEM_RX_ACCEPT: accept
>   */

It would be nice to update this comment about the return value rather
than just deleting it. I think the new semantics are
"Returns a GEM_RX_ constant, or a valid SAR", right
(though I may have mangled the SAR terminology, feel free to
correct/expand).

thanks
-- PMM