Re: [Qemu-devel] [PATCH arm-devs v4 4/4] cpu/a9mpcore: Add Global Timer

[Paolo Bonzini]

Il 02/12/2013 14:08, Andreas Färber ha scritto:
>> > +    object_initialize(&s->gtimer, sizeof(s->gtimer), TYPE_A9_GTIMER);
>> > +    qdev_set_parent_bus(DEVICE(&s->gtimer), sysbus_get_default());
>> > +
>> >      object_initialize(&s->mptimer, sizeof(s->mptimer), TYPE_ARM_MPTIMER);
>> >      qdev_set_parent_bus(DEVICE(&s->mptimer), sysbus_get_default());
>> >  
> This code resulted from inlining qdev_create() and switching to in-place
> instantiation.
> 
> Seeing this repetitive code again and again makes me wonder whether we
> can just set a SysBusDevice's parent_bus in its instance_init function
> to simplify it?

Could we do it instead in the init function, only if parent_bus is still
NULL?

Paolo