qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotes


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py
Date: Tue, 3 Dec 2013 16:19:26 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 03.12.2013 um 15:27 hat Benoît Canet geschrieben:
> Le Tuesday 03 Dec 2013 à 16:25:23 (+0800), Fam Zheng a écrit :
> > This will allow overriding cache mode from the "-c mode" option.
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  tests/qemu-iotests/iotests.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> > index fb10ff4..c84a1a5 100644
> > --- a/tests/qemu-iotests/iotests.py
> > +++ b/tests/qemu-iotests/iotests.py
> > @@ -37,6 +37,7 @@ qemu_args = os.environ.get('QEMU', 
> > 'qemu').strip().split(' ')
> >  imgfmt = os.environ.get('IMGFMT', 'raw')
> >  imgproto = os.environ.get('IMGPROTO', 'file')
> >  test_dir = os.environ.get('TEST_DIR', '/var/tmp')
> > +cachemode = os.environ.get('CACHEMODE')
> +cachemode = os.environ.get('CACHEMODE', "none")
> 
> This way the default would be preserved.

CACHEMODE is always set, so you'd never get the default anyway. If
anything, it would have to use that other environment variable that
tells us if we're running the default. It's probably not necessary,
though.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]