[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced |
Date: |
Mon, 9 Dec 2013 16:02:09 +0200 |
On Mon, Dec 09, 2013 at 01:36:54PM +0100, Stefan Hajnoczi wrote:
> On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote:
> > - This patch is against the net-next tree
> > (https://github.com/stefanha/qemu.git)
> > because the first netmap patch is not in the qemu master (AFAIK).
>
> You are right. I am sending a pull request now to get those patches
> into qemu.git/master.
This only arrived over the weekend and affects all
net devices. Whats the rush?
Why not give people a chance to review and discuss
properly?
> > hw/net/cadence_gem.c | 3 ++-
> > hw/net/dp8393x.c | 5 +++--
> > hw/net/e1000.c | 21 ++++++++++++++++-----
> > hw/net/eepro100.c | 5 +++--
> > hw/net/etraxfs_eth.c | 5 +++--
> > hw/net/lan9118.c | 2 +-
> > hw/net/mcf_fec.c | 5 +++--
> > hw/net/mipsnet.c | 6 ++++--
> > hw/net/ne2000.c | 5 +++--
> > hw/net/ne2000.h | 3 ++-
> > hw/net/opencores_eth.c | 2 +-
> > hw/net/pcnet.c | 8 +++++---
> > hw/net/pcnet.h | 3 ++-
> > hw/net/rtl8139.c | 7 ++++---
> > hw/net/smc91c111.c | 5 +++--
> > hw/net/spapr_llan.c | 2 +-
> > hw/net/stellaris_enet.c | 3 ++-
> > hw/net/virtio-net.c | 10 ++++++++--
> > hw/net/vmxnet3.c | 3 ++-
> > hw/net/vmxnet_tx_pkt.c | 4 ++--
> > hw/net/xgmac.c | 2 +-
> > hw/net/xilinx_axienet.c | 2 +-
> > hw/usb/dev-network.c | 8 +++++---
> > include/net/net.h | 20 +++++++++++++-------
> > include/net/queue.h | 1 +
> > net/dump.c | 3 ++-
> > net/hub.c | 10 ++++++----
> > net/net.c | 39 +++++++++++++++++++++++----------------
> > net/netmap.c | 17 ++++++++++++-----
> > net/slirp.c | 5 +++--
> > net/socket.c | 10 ++++++----
> > net/tap-win32.c | 2 +-
> > net/tap.c | 12 +++++++-----
> > net/vde.c | 5 +++--
> > savevm.c | 2 +-
> > 35 files changed, 155 insertions(+), 90 deletions(-)
>
> Please split this into multiple patches:
>
> 1. net subsystem API change that touches all files (if necessary)
> 2. e1000 MORE support
> 3. virtio-net MORE support
> 4. netmap MORE support
>
> This makes it easier to review and bisect.
>
> Thanks,
> Stefan
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, (continued)
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Vincenzo Maffione, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Michael S. Tsirkin, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Vincenzo Maffione, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Michael S. Tsirkin, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Stefan Hajnoczi, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Vincenzo Maffione, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Michael S. Tsirkin, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Vincenzo Maffione, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Michael S. Tsirkin, 2013/12/09
Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced, Stefan Hajnoczi, 2013/12/09
- Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced,
Michael S. Tsirkin <=