Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost

[Gerd Hoffmann]

On Di, 2013-12-10 at 06:42 +0100, Stefan Weil wrote:
> Am 10.12.2013 05:05, schrieb Dave Airlie:
> > Hi,
> >
> > This is a repost of the latest SDL2 UI layer along with virtio-gpu,
> >
> > I've merged the SDL2 base and multi-head patches into one, and I've split
> > out the display notifiers stuff and the sdl2 demo hack.
> >
> > The virtio-gpu/vga wrapping is still unresolved, I've failed to find a 
> > cleaner
> > way yet, hopefully Gerd will advise further, but having 4 virtio-gpu- 
> > objects
> > we getting ugly fast. I've also included a doc on the basic queues used in 
> > the
> > virtio-gpu and what commands are sent on them.
> >
> > I'd really like to get the sdl2 base patch merged at least,
> >
> > Dave.
> 
> I did not review all patches in the series, but stopped at the first one
> which had style issues.
> 
> Please check your patches using scripts/checkpatch.pl.

To be fair most of this comes from ui/sdl.c not conforming to qemu code
style, because the code predates the current qemu code style.

Nevertheless it is a good idea to hook up scripts/checkpatch.pl in the
git pre-commit.

cheers,
  Gerd