[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v2.0)
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v2.0) |
Date: |
Thu, 12 Dec 2013 13:53:37 +0100 |
On Mi, 2013-12-11 at 11:12 +1000, Dave Airlie wrote:
> On Wed, Dec 11, 2013 at 12:35 AM, Gerd Hoffmann <address@hidden> wrote:
> > Hi,
> >
> >> The biggest changes were in the input handling, where SDL2 has done a major
> >> overhaul, and I've had to include a generated translation file to get from
> >> SDL2 codes back to qemu compatible ones. I'm still not sure how the
> >> keyboard
> >> layout code works in qemu, so there may be further work if someone can
> >> point
> >> me a test case that works with SDL1.2 and doesn't with SDL2.
> >
> > I've picked it up, cleaned up a bit (more to be done), switched over to
> > new input core. Simplified the keyboard mess, the new input support in
> > SDL2 allows us to reduce it to a single+simple lookup table. Pushed
> > here:
>
> Oh thanks for that, looks a lot cleaner esp the input handling, let me
> know if there
> is anything you'd like me to look at.
Testing would be nice (but take care a bit, the branch is a moving
target, i.e. rebases), other than that nothing for now.
I wanna get the input patch series out-of-the-door asap, probably with
the sdl2 bits sprinkled in at the correct places so the whole thing is
bisectable.
> I wasn't sure if we wanted to keep the old text console switching
> stuff on console 0 or not,
> I see you've ripped it out, I can't say I ever used it anyways.
It's pointless if we explicitly bind to a specific console. The
switching would change active_console, but you wouldn't see it.
cheers,
Gerd
- [Qemu-devel] [RFC] sdl2 + virtio-gpu repost, Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display, Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 3/8] sdl2: add display notify change support, Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 4/8] sdl2: add UI to toggle head 1 on/off, Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 5/8] console: add ability to wrap a console., Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.2 of the virtio based GPU code., Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 7/8] virtio-vga: v1, Dave Airlie, 2013/12/09
- [Qemu-devel] [PATCH 8/8] HACK: just to make things start easier with libvirt, Dave Airlie, 2013/12/09
- Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost, Dave Airlie, 2013/12/09
- Re: [Qemu-devel] [RFC] sdl2 + virtio-gpu repost, Stefan Weil, 2013/12/10