[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negative
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64 |
Date: |
Fri, 13 Dec 2013 00:13:28 +0000 |
On 9 December 2013 15:47, Tom Musta <address@hidden> wrote:
> The float64_to_uint64 routine exits early for all negative numbers.
> While the integer result is always correctly returned as 0, the
> exception flags are also always set to float_flag_invalid. This
> is incorrect for those cases where a small negative number (-1 < x < 0)
> rounds to zero. In such a case, the flag should be reported as
> inexact.
> -static int64 roundAndPackUint64(uint64_t absZ0, uint64_t absZ1 STATUS_PARAM)
> +static int64 roundAndPackUint64(flag zSign, uint64_t absZ0,
> + uint64_t absZ1 STATUS_PARAM)
This function isn't in the copy of fpu/softfloat.c that's in master,
unless I'm confused. Does this series depend on something else?
thanks
-- PMM
- [Qemu-devel] [PATCH 05/18] target-ppc: Add ISA 2.06 divwe[u][o] Instructions, (continued)
- [Qemu-devel] [PATCH 07/18] target-ppc: Add ISA 2.06 stbcx. and sthcx. Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 06/18] target-ppc: Add ISA2.06 lbarx, lharx Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 08/18] target-ppc: Add ISA2.06 Float to Integer Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64, Tom Musta, 2013/12/09
- Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64,
Peter Maydell <=
[Qemu-devel] [PATCH 10/18] softfloat: Fix float64_to_uint64_round_to_zero, Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 11/18] softfloat: Fix float64_to_uint32, Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 12/18] softfloat: Fix float64_to_uint32_round_to_zero, Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 13/18] target-ppc: Add ISA 2.06 fcfid[u][s] Instructions, Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 14/18] target-ppc: Fix and enable fri[mnpz], Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 15/18] target-ppc: Add ISA 2.06 ftdiv Instruction, Tom Musta, 2013/12/09
[Qemu-devel] [PATCH 16/18] target-ppc: Add ISA 2.06 ftsqrt, Tom Musta, 2013/12/09