[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] monitor: add object-add (QMP) and object_ad

From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH 4/5] monitor: add object-add (QMP) and object_add (HMP) command
Date: Fri, 13 Dec 2013 10:55:31 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

于 2013/12/11 2:15, Paolo Bonzini 写道:
Hash: SHA1

Il 10/12/2013 19:00, Eric Blake ha scritto:
+  'data': {'qom-type': 'str', 'id': 'str', '*props': 'dict'},
+  'gen': 'no' }

This feels VERY open-coded.  No where else in qapi-schema do we
have 'dict' as a type

Yes, in fact the "data" field is entirely skipped by the code
generator (that's 'gen':'no').

Could we use hmp_object_add()->qmp_object_add()->object_add() code path,
instead of  hmp_object_add()->object_add(),qmp_object_add()->object_add()?
Would skipping by generator brings some difficult to it?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]