Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration

[Max Reitz]

On 13.12.2013 21:36, Kevin Wolf wrote:
> Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> > Introduce the "image" option as an alternative to specifying the image
> > through the filename.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> One thing I'd like to see, either in the next version or in a follow-up
> series, is to generalise open_image() into a block.c function.

Yes, I thought of something like that myself. I think, eventually we 
need to merge bdrv_open() and bdrv_file_open() (now that "file"s can be 
nested and there may be block devices without "file"s, there is no 
actual need to separate both).

> The main difference between blkdebug and blkverify seems to be that
> blkverify does image format probing on its main image. This can be a
> bool argument to open_image().

I think, blkdebug should just force the raw driver with a common 
open_image().

Max