[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props |
Date: |
Sun, 15 Dec 2013 21:55:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Peter,
Am 29.11.2013 10:43, schrieb address@hidden:
> From: Markus Armbruster <address@hidden>
>
> Pointer properties can be set only by code, not by device_add. A
> device with a pointer property can work with device_add only when the
> property may remain null.
>
> This is the case for property "interrupt_vector" of device
> "etraxfs,pic". Add a comment there.
>
> Set cannot_instantiate_with_device_add_yet for the other devices with
> pointer properties, with a comment explaining why.
>
> Juha Riihimäki and Peter Maydell deserve my thanks for making "pointer
> property must not remain null" blatantly obvious in the OMAP devices.
>
> Only device "smbus-eeprom" is actually changed. The others are all
> sysbus devices, which get cannot_instantiate_with_device_add_yet set
> in their abstract base's class init function. Setting it again in
> their class init function is technically redundant, but serves as
> insurance for when sysbus devices become available with device_add,
> and as documentation.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/audio/marvell_88w8618.c | 2 ++
> hw/dma/sparc32_dma.c | 2 ++
> hw/gpio/omap_gpio.c | 4 ++++
> hw/i2c/omap_i2c.c | 2 ++
> hw/i2c/smbus_eeprom.c | 2 ++
> hw/intc/etraxfs_pic.c | 4 ++++
> hw/intc/grlib_irqmp.c | 2 ++
> hw/intc/omap_intc.c | 4 ++++
> hw/net/etraxfs_eth.c | 2 ++
> hw/net/lance.c | 2 ++
> 10 files changed, 26 insertions(+)
Since you're mentioned by name, should I wait for you to review the
three OMAP parts?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props,
Andreas Färber <=