[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bit
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits |
Date: |
Tue, 17 Dec 2013 16:26:00 +0100 |
This operation is way faster than doing it bit by bit.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/exec/memory-internal.h | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index c04a92a..b017c2e 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -44,19 +44,15 @@ static inline bool cpu_physical_memory_get_dirty(ram_addr_t
start,
ram_addr_t length,
unsigned client)
{
- ram_addr_t addr, end;
+ unsigned long end, page, next;
assert(client < DIRTY_MEMORY_NUM);
- end = TARGET_PAGE_ALIGN(start + length);
- start &= TARGET_PAGE_MASK;
- for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
- if (test_bit(addr >> TARGET_PAGE_BITS,
- ram_list.dirty_memory[client])) {
- return true;
- }
- }
- return false;
+ end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS;
+ page = start >> TARGET_PAGE_BITS;
+ next = find_next_bit(ram_list.dirty_memory[client], end, page);
+
+ return next < end;
}
static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
--
1.8.3.1
- Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, (continued)
- [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 21/38] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits,
Juan Quintela <=
- [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 27/38] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty(), Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 29/38] memory: cpu_physical_memory_set_dirty_tracking() should return void, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 28/38] memory: make cpu_physical_memory_reset_dirty() take a length parameter, Juan Quintela, 2013/12/17