[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* a
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages |
Date: |
Thu, 19 Dec 2013 10:06:00 +0000 |
On 17 December 2013 15:26, Juan Quintela <address@hidden> wrote:
> @@ -399,8 +401,9 @@ static int
> kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
> page_number = (i * HOST_LONG_BITS + j) * hpratio;
> addr1 = page_number * TARGET_PAGE_SIZE;
> addr = section->offset_within_region + addr1;
> - memory_region_set_dirty(section->mr, addr,
> - TARGET_PAGE_SIZE * hpratio);
> + ram_addr = section->mr->ram_addr + addr;
struct MemoryRegion says:
/* All fields are private - violators will be prosecuted */
so fishing around in it for mr->ram_addr seems like a bad idea.
Perhaps we could make memory_region_set_dirty() an inline
function in memory.h instead?
thanks
-- PMM
- [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, (continued)
- [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 28/38] memory: make cpu_physical_memory_reset_dirty() take a length parameter, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 30/38] memory: split cpu_physical_memory_* functions to its own include, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 31/38] memory: unfold memory_region_test_and_clear(), Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 33/38] kvm: refactor start address calculation, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 34/38] memory: move bitmap synchronization to its own function, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 35/38] memory: syncronize kvm bitmap using bitmaps operations, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 36/38] ram: split function that synchronizes a range, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 37/38] migration: synchronize memory bitmap 64bits at a time, Juan Quintela, 2013/12/17