Re: [Qemu-devel] [RFC] test: QOM interface casting

[Igor Mammedov]

On Fri, 20 Dec 2013 13:47:32 +0100
Andreas Färber <address@hidden> wrote:

> Hi,
> 
> Am 20.12.2013 12:08, schrieb Igor Mammedov:
> > ---
> >  tests/Makefile              |    3 +
> >  tests/check-qom-interface.c |  102 
> > +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 105 insertions(+), 0 deletions(-)
> >  create mode 100644 tests/check-qom-interface.c
> 
> Apart from the style issues and typos that the two Peter's have pointed
> out, I'd like to point out that this is missing Signed-off-by and commit
> message. In particular, is this a test that should be committed
> alongside the interface cast fixes or anything else that I have queued?
> Or just to improve overall test coverage? Either way I'm in favor of
> having them.
Since interfaces are not widely used it's easy to break them, this adds
regression testing. It could go along with fixes you've queued.

> 
> Concerning PMM's comment, don't we already have a qdev properties unit
> test from Eduardo where we might share QOM dependencies via some
> Makefile variable? Grouping the check-* tests also makes sense to me
> than just adding at the bottom.
> 
> Anything in particular that you'd like comments on, this being an RFC?
Peters's and your comments are applied, I'll respin it as patch,
thanks for reviewing.

> Regards,
> Andreas
>