[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v4 2/8] hw: arm_gic: Introduce gic_set_priority
From: |
Christoffer Dall |
Subject: |
[Qemu-devel] [RFC PATCH v4 2/8] hw: arm_gic: Introduce gic_set_priority function |
Date: |
Fri, 20 Dec 2013 22:09:33 -0800 |
To make the code slightly cleaner to look at and make the save/restore
code easier to understand, introduce this function to set the priority of
interrupts.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Christoffer Dall <address@hidden>
---
hw/intc/arm_gic.c | 15 ++++++++++-----
hw/intc/gic_internal.h | 1 +
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 27c258a..6c59650 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@ -168,6 +168,15 @@ uint32_t gic_acknowledge_irq(GICState *s, int cpu)
return new_irq;
}
+void gic_set_priority(GICState *s, int cpu, int irq, uint8_t val)
+{
+ if (irq < GIC_INTERNAL) {
+ s->priority1[irq][cpu] = val;
+ } else {
+ s->priority2[(irq) - GIC_INTERNAL] = val;
+ }
+}
+
void gic_complete_irq(GICState *s, int cpu, int irq)
{
int update = 0;
@@ -443,11 +452,7 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
irq = (offset - 0x400) + GIC_BASE_IRQ;
if (irq >= s->num_irq)
goto bad_reg;
- if (irq < GIC_INTERNAL) {
- s->priority1[irq][cpu] = value;
- } else {
- s->priority2[irq - GIC_INTERNAL] = value;
- }
+ gic_set_priority(s, cpu, irq, value);
} else if (offset < 0xc00) {
/* Interrupt CPU Target. RAZ/WI on uniprocessor GICs, with the
* annoying exception of the 11MPCore's GIC.
diff --git a/hw/intc/gic_internal.h b/hw/intc/gic_internal.h
index efac78d..8c02d58 100644
--- a/hw/intc/gic_internal.h
+++ b/hw/intc/gic_internal.h
@@ -61,5 +61,6 @@ uint32_t gic_acknowledge_irq(GICState *s, int cpu);
void gic_complete_irq(GICState *s, int cpu, int irq);
void gic_update(GICState *s);
void gic_init_irqs_and_distributor(GICState *s, int num_irq);
+void gic_set_priority(GICState *s, int cpu, int irq, uint8_t val);
#endif /* !QEMU_ARM_GIC_INTERNAL_H */
--
1.8.5
- [Qemu-devel] [RFC PATCH v4 0/8] Support arm-gic-kvm save/restore, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 1/8] arm_gic: Rename GIC_X_TRIGGER to GIC_X_EDGE_TRIGGER, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 2/8] hw: arm_gic: Introduce gic_set_priority function,
Christoffer Dall <=
- [Qemu-devel] [RFC PATCH v4 3/8] arm_gic: Fix GIC pending behavior, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 4/8] hw: arm_gic: Keep track of SGI sources, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 5/8] arm_gic: Support setting/getting binary point reg, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 6/8] vmstate: Add uint32 2D-array support, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 7/8] arm_gic: Add GICC_APRn state to the GICState, Christoffer Dall, 2013/12/21
- [Qemu-devel] [RFC PATCH v4 8/8] hw: arm_gic_kvm: Add KVM VGIC save/restore logic, Christoffer Dall, 2013/12/21