qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/25] target-arm: Remove ARMCPU/CPUARMState


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 13/25] target-arm: Remove ARMCPU/CPUARMState from cpregs APIs used by decoder
Date: Mon, 23 Dec 2013 12:11:21 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 12/22/2013 02:49 PM, Peter Maydell wrote:
> The cpregs APIs used by the decoder (get_arm_cp_reginfo() and
> cp_access_ok()) currently take either a CPUARMState* or an ARMCPU*.
> This is problematic for the A64 decoder, which doesn't pass the
> environment pointer around everywhere the way the 32 bit decoder
> does. Adjust the parameters these functions take so that we can
> copy only the relevant info from the CPUARMState into the
> DisasContext and then use that.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target-arm/cpu.h           |  6 +++---
>  target-arm/helper.c        | 12 ++++++------
>  target-arm/translate-a64.c |  2 ++
>  target-arm/translate.c     |  7 ++++---
>  target-arm/translate.h     |  2 ++
>  5 files changed, 17 insertions(+), 12 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]