[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/17] exynos4210: Use macro ARRAY_SIZE where possibl
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 05/17] exynos4210: Use macro ARRAY_SIZE where possible |
Date: |
Sat, 28 Dec 2013 02:07:18 +0400 |
From: Stefan Weil <address@hidden>
This improves readability and simplifies the code.
Cc: Dmitry Solodkiy <address@hidden>
Cc: Evgeny Voevodin <address@hidden>
Cc: Igor Mitsyanko <address@hidden>
Cc: Maksim Kozlov <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/char/exynos4210_uart.c | 6 ++----
hw/misc/exynos4210_pmu.c | 3 +--
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index eef23a0..19b59cc 100644
--- a/hw/char/exynos4210_uart.c
+++ b/hw/char/exynos4210_uart.c
@@ -192,10 +192,9 @@ typedef struct Exynos4210UartState {
static const char *exynos4210_uart_regname(hwaddr offset)
{
- int regs_number = sizeof(exynos4210_uart_regs) / sizeof(Exynos4210UartReg);
int i;
- for (i = 0; i < regs_number; i++) {
+ for (i = 0; i < ARRAY_SIZE(exynos4210_uart_regs); i++) {
if (offset == exynos4210_uart_regs[i].offset) {
return exynos4210_uart_regs[i].name;
}
@@ -544,10 +543,9 @@ static void exynos4210_uart_event(void *opaque, int event)
static void exynos4210_uart_reset(DeviceState *dev)
{
Exynos4210UartState *s = EXYNOS4210_UART(dev);
- int regs_number = sizeof(exynos4210_uart_regs)/sizeof(Exynos4210UartReg);
int i;
- for (i = 0; i < regs_number; i++) {
+ for (i = 0; i < ARRAY_SIZE(exynos4210_uart_regs); i++) {
s->reg[I_(exynos4210_uart_regs[i].offset)] =
exynos4210_uart_regs[i].reset_value;
}
diff --git a/hw/misc/exynos4210_pmu.c b/hw/misc/exynos4210_pmu.c
index cbf0795..5ec14d1 100644
--- a/hw/misc/exynos4210_pmu.c
+++ b/hw/misc/exynos4210_pmu.c
@@ -383,8 +383,7 @@ static const Exynos4210PmuReg exynos4210_pmu_regs[] = {
{"GPS_ALIVE_OPTION", GPS_ALIVE_OPTION, 0x00000001},
};
-#define PMU_NUM_OF_REGISTERS \
- (sizeof(exynos4210_pmu_regs) / sizeof(Exynos4210PmuReg))
+#define PMU_NUM_OF_REGISTERS ARRAY_SIZE(exynos4210_pmu_regs)
#define TYPE_EXYNOS4210_PMU "exynos4210.pmu"
#define EXYNOS4210_PMU(obj) \
--
1.7.10.4
- [Qemu-devel] [PULL 00/17] trivial patches for 2013-12-27, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 01/17] hw/arm/highbank: Simplify code (memory region in device state), Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 05/17] exynos4210: Use macro ARRAY_SIZE where possible,
Michael Tokarev <=
- [Qemu-devel] [PULL 03/17] misc: Use macro ARRAY_SIZE where possible, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 02/17] openrisc: Fix spelling in comment (transaltion -> translation), Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 07/17] x86: only allow real mode to access 32bit without LMA, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 08/17] vl: make boot_strict variable static (not used outside vl.c), Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 15/17] pxa27x: Add 'const' attribute to keyboard maps, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 06/17] linux-user: Use macro TARGET_NSIG_WORDS where possible, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 11/17] configure: Rewrite code for help message, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 09/17] fix -boot strict regressed in commit 6ef4716, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 12/17] configure: Python tests must be done before help message, Michael Tokarev, 2013/12/27
- [Qemu-devel] [PULL 17/17] acpi unit-test: Remove temporary disk after test, Michael Tokarev, 2013/12/27