Re: [Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to_zero

[Richard Henderson]

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> From: Tom Musta <address@hidden>
> 
> The float64_to_uint64_round_to_zero routine is incorrect.
> 
> For example, the following test pattern:
> 
>     46697351FF4AEC29 / 0x1.97351ff4aec29p+103
> 
> currently produces 8000000000000000 instead of FFFFFFFFFFFFFFFF.
> 
> This patch re-implements the routine to temporarily force the
> rounding mode and use the float64_to_uint64 routine.
> 
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
> 
> Signed-off-by: Tom Musta <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  fpu/softfloat.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)

Perhaps a duplicate with Tom's thread, but:

Reviewed-by: Richard Henderson <address@hidden>


r~