[Qemu-devel] Virtual VFAT with floppy option doesn't work

[Kiyokazu SUTO]

Hi,

Virtual VFAT mechanism in recent releases does not work with the
floppy option, because, in `vvfat_open()' function, the member
`first_sectors_number' is overwritten with the value for HDD even when
the floppy option presents.  I attach the diff output just to clarify
the problem.

Sorry if this has been already fixed in the git repository.

Regards,
-- 
SUTO, Kiyokazu <address@hidden>
http://pub.ks-and-ks.ne.jp/pgp-public-key.html

diff -up qemu-1.7.0/block/vvfat.c{-dist,}
--- qemu-1.7.0/block/vvfat.c-dist       2013-11-28 07:15:55.000000000 +0900
+++ qemu-1.7.0/block/vvfat.c    2014-01-06 07:03:45.000000000 +0900
@@ -1123,6 +1123,7 @@ DLOG(if (stderr == NULL) {
         if (!s->fat_type) {
             s->fat_type = 16;
         }
+       s->first_sectors_number=0x40;
         cyls = s->fat_type == 12 ? 64 : 1024;
         heads = 16;
         secs = 63;
@@ -1151,7 +1152,6 @@ DLOG(if (stderr == NULL) {
 
     s->current_cluster=0xffffffff;
 
-    s->first_sectors_number=0x40;
     /* read only is the default for safety */
     bs->read_only = 1;
     s->qcow = s->write_target = NULL;