[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1 |
Date: |
Tue, 7 Jan 2014 13:00:04 -0800 |
By inspection, obviously we should be storing T[1] not T[0].
This could only happen for x86_64 in 64-bit mode with 0x66
prefix to call insn -- i.e. never.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index a1a23a6..9205b72 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2488,7 +2488,7 @@ static void gen_push_T1(DisasContext *s)
gen_op_st_v(s, MO_64, cpu_T[1], cpu_A0);
} else {
gen_op_addq_A0_im(-2);
- gen_op_st_v(s, MO_16, cpu_T[0], cpu_A0);
+ gen_op_st_v(s, MO_16, cpu_T[1], cpu_A0);
}
gen_op_mov_reg_A0(2, R_ESP);
} else
--
1.8.4.2
- [Qemu-devel] [PULL 05/49] target-i386: Use new tcg_gen_qemu_st_* helpers, (continued)
- [Qemu-devel] [PULL 05/49] target-i386: Use new tcg_gen_qemu_st_* helpers, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 03/49] target-i386: Stop encoding DisasContext.mem_index, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 07/49] target-i386: Remove gen_op_ld_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 08/49] target-i386: Remove gen_op_ldu_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 09/49] target-i386: Remove gen_op_ld_T1_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 10/49] target-i386: Remove gen_op_lds_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 11/49] target-i386: Introduce gen_op_st_rm_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 06/49] target-i386: Replace OT_* constants with MO_* constants, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 12/49] target-i386: Remove gen_op_st_T0_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 13/49] target-i386: Remove gen_op_st_T1_A0, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1,
Richard Henderson <=
- [Qemu-devel] [PULL 15/49] target-i386: Tidy mov[sz][bw], Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 16/49] target-i386: Tidy movsl, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 17/49] target-i386: Remove unused arguments to gen_lea_modrm, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 18/49] target-i386: Use MO_BE for movbe, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 19/49] target-i386: Tidy gen_op_mov_TN_reg+tcg_gen_trunc_tl_i32, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 20/49] target-i386: Tidy load + truncate, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 21/49] target-i386: Tidy extend + store, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 22/49] target-i386: Tidy extend + move, Richard Henderson, 2014/01/07
- [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*, Richard Henderson, 2014/01/07