Re: [Qemu-devel] [PATCH] tests: fix acpi to work on bigendian host

[Michael S. Tsirkin]

On Mon, Jan 13, 2014 at 06:33:53PM +1100, Alexey Kardashevskiy wrote:
> Double endianness convertion make this test failing on POWERPC machine
> running in big-endian.
> 
> This fixes the test to success on big-endian host.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

Yes, readl etc already convert from guest endian-ness to host
endian-ness, and guest is LE.

Applied, thanks.

> ---
>  tests/acpi-test.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/acpi-test.c b/tests/acpi-test.c
> index df1af83..30a5e3e 100644
> --- a/tests/acpi-test.c
> +++ b/tests/acpi-test.c
> @@ -51,13 +51,13 @@ typedef struct {
>              field = readb(addr);               \
>              break;                             \
>          case 2:                                \
> -            field = le16_to_cpu(readw(addr));  \
> +            field = readw(addr);               \
>              break;                             \
>          case 4:                                \
> -            field = le32_to_cpu(readl(addr));  \
> +            field = readl(addr);               \
>              break;                             \
>          case 8:                                \
> -            field = le64_to_cpu(readq(addr));  \
> +            field = readq(addr);               \
>              break;                             \
>          default:                               \
>              g_assert(false);                   \
> -- 
> 1.8.4.rc4
>