qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC F


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller
Date: Fri, 17 Jan 2014 11:25:21 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Jan 16, 2014 at 10:52:19PM +1000, Peter Crosthwaite wrote:
> > Perhaps we should just rely on
> > NetClient->link_ok.
> >
> 
> I think we are in agreement then? There is no need for phy.link_ok as
> same information is captured in NetClient. This means there is no
> link_ok field to migrate. Just migrate the phy registers themselves.
> 
> For completeness you just need to poll NetClient state post_load which
> will nicely handle my degenerate case of link activity between save
> and load (same handler as link_state_changed). In the more usual case
> of the link state not changing between save and load, this function
> call will just be a nop, leading to no change of state on the freshly
> migrated phy registers.

Sounds good.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]