qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for,


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for, reading/writing registers
Date: Mon, 20 Jan 2014 15:33:26 +0100

On 17.01.2014, at 22:02, Thomas Falcon <address@hidden> wrote:

> This patch allows registers to be properly read from and written to
> when using the gdbstub to debug a ppc guest running in little
> endian mode.  It accomplishes this goal by byte swapping the values of
> any registers if the MSR:LE value is set.
> 
> Signed-off-by: Thomas Falcon <address@hidden>
> ---
> Differences from v2:
> 
> Fixed formatting issues
> Added logic to ensure only FP registers have a guaranteed size of 8 bytes


I don't really like how the write case has to know about the size of a register 
(maybe we could factor this out into a single function for all reads and 
writes?), but this is good enough for now :). However, I can't apply the patch 
as your email client seems to have broken the patch formatting.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]