[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD |
|
Date: |
Tue, 21 Jan 2014 07:38:00 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/18/2014 05:59 AM, Peter Maydell wrote:
> On 18 January 2014 13:47, Martin Husemann <address@hidden> wrote:
>> Do not rely on int8_t (and friends) not being preprocessor
>> symbols (or symbols expanding to themselves). On NetBSD (for example) the
>> glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no
>> way
>> to stop cpp expanding inner macros, so just add the few lines explicitly and
>> get rid of the magic.
>>
>> Signed-off-by: Martin Husemann <address@hidden>
>
> Reviewed-by: Peter Maydell <address@hidden>
>
> This was introduced in commit c8f94df593.
> Richard, do you want to take this fix via the tcg tree, or should it
> go via trivial?
Trivial is fine. Saves me the effort. ;-)
r~