[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13 v7] dump: const-qualify the buf of WriteCo
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 01/13 v7] dump: const-qualify the buf of WriteCoreDumpFunction |
Date: |
Wed, 22 Jan 2014 16:48:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131118 Thunderbird/17.0.11 |
On 01/17/14 08:46, qiaonuohan wrote:
> WriteCoreDumpFunction is a function pointer that points to the function used
> to
> write content in "buf" into core file, so "buf" should be const-qualify.
>
> Signed-off-by: Qiao Nuohan <address@hidden>
> ---
> dump.c | 2 +-
> include/qom/cpu.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dump.c b/dump.c
> index 80a9116..42622de 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -99,7 +99,7 @@ static void dump_error(DumpState *s, const char *reason)
> dump_cleanup(s);
> }
>
> -static int fd_write_vmcore(void *buf, size_t size, void *opaque)
> +static int fd_write_vmcore(const void *buf, size_t size, void *opaque)
> {
> DumpState *s = opaque;
> size_t written_size;
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 7739e00..57b4164 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -28,7 +28,8 @@
> #include "qemu/tls.h"
> #include "qemu/typedefs.h"
>
> -typedef int (*WriteCoreDumpFunction)(void *buf, size_t size, void *opaque);
> +typedef int (*WriteCoreDumpFunction)(const void *buf, size_t size,
> + void *opaque);
>
> /**
> * vaddr:
>
Reviewed-by: Laszlo Ersek <address@hidden>