[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block/vmdk: add basic .bdrv_check support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block/vmdk: add basic .bdrv_check support |
Date: |
Mon, 27 Jan 2014 16:37:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 13, 2014 at 12:24:06PM +0100, Peter Lieven wrote:
> + for (;;) {
> + if (sector_num >= total_sectors) {
> + return 0;
> + }
> + extent = find_extent(s, sector_num, extent);
> + if (!extent) {
> + fprintf(stderr, "ERROR: could not find extend for sector %ld\n",
> + sector_num);
s/extend/extent/
Please use PRId64 instead of %ld so this works on 32-bit hosts.
> + break;
> + }
> + ret = get_cluster_offset(bs, extent, NULL, sector_num <<
> BDRV_SECTOR_BITS,
> + 0, &cluster_offset);
> + if (ret == VMDK_ERROR) {
> + fprintf(stderr,
> + "ERROR: could not get cluster_offset for sector %ld\n",
PRId64
> + sector_num);
> + break;
> + }
> + if (ret == VMDK_OK && cluster_offset >=
> bdrv_getlength(extent->file)) {
> + fprintf(stderr,
> + "ERROR: cluster offset for sector %ld points after
> EOF\n",
PRId64