Re: [Qemu-devel] [PATCH v4 2/3] hw/net: add support for Allwinner EMAC Fast Ethernet controller

[Peter Maydell]

On 26 January 2014 21:39, Beniamino Galvani <address@hidden> wrote:
> This patch adds support for the Fast Ethernet MAC found on Allwinner
> SoCs, together with a basic emulation of Realtek RTL8201CP PHY.
>
> Since there is no public documentation of the Allwinner controller, the
> implementation is based on Linux kernel driver.

It would be nice to mention that the device model is based
from reverse-engineering from the Linux kernel sources in a
comment in the allwinner_emac.c too, for the benefit of anybody
else trying to deal with the model later.

> --- /dev/null
> +++ b/include/hw/net/allwinner_emac.h
> @@ -0,0 +1,211 @@
> +/*
> + * Emulation of Allwinner EMAC Fast Ethernet controller and
> + * Realtek RTL8201CP PHY
> + *
> + * Copyright (C) 2014 Beniamino Galvani <address@hidden>
> + *
> + * Allwinner EMAC register definitions from Linux kernel are:
> + *   Copyright 2012 Stefan Roese <address@hidden>
> + *   Copyright 2013 Maxime Ripard <address@hidden>
> + *   Copyright 1997 Sten Wang
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

Either the register definitions are significant enough for
copyright to apply, in which case the license comes with
them and they must be GPLv2-only (since that's what the Linux
kernel is), or they're not significant enough, in which case
you can ditch the copyright attribution.

I would suggest you err on the safe side and make this file
GPLv2-only.

If you fix those two things you can mark your next version
of this patch
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM