Re: [Qemu-devel] [PATCH 16/18] bsd-user: add support for extended attribute and ACL related syscalls

[Peter Maydell]

On 16 October 2013 15:37, Stacey Son <address@hidden> wrote:
> This change add support for extended attribute and Access Control List
> (ACL) related system calls including extattrctl(), extattr_set_file(2),
> extattr_delete_file(2), extattr_set_fd(2), extattr_get_fd(2),
> extattr_delete_fd(2), extattr_get_link(2), extattr_set_link(2),
> extattr_delete_link(2), extattr_list_fd(2), extattr_list_file(2),
> extattr_list_link(2), __acl_aclcheck_fd(), __acl_aclcheck_file(),
> __acl_aclcheck_link(), __acl_delete_fd(), __acl_delete_file(),
> __acl_delete_link(), __acl_get_fd(), __acl_get_file(), __acl_get_link(),
> __acl_get_fd(), __acl_set_file(), and __acl_set_link().
>
> Signed-off-by: Stacey Son <address@hidden>
> ---
>  bsd-user/Makefile.objs        |    2 +-
>  bsd-user/freebsd/os-extattr.c |  119 ++++++++
>  bsd-user/freebsd/os-extattr.h |  644 
> +++++++++++++++++++++++++++++++++++++++++
>  bsd-user/freebsd/qemu-os.h    |    6 +
>  bsd-user/netbsd/os-extattr.h  |  247 ++++++++++++++++
>  bsd-user/openbsd/os-extattr.h |  247 ++++++++++++++++

This is 500 lines of boilerplate just to say "these
system calls aren't implemented for these host OSes".
That's way too many; isn't there a better way to do this?
(Applies similarly to all these syscall-implementing
patches.)

thanks
-- PMM