[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types |
Date: |
Thu, 30 Jan 2014 17:26:17 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/28/2014 02:56 AM, Gerd Hoffmann wrote:
> Define input event types, using qapi. So we get nicely autogenerated
> types for our input events. And when it comes to qmp support some day
> things will be alot easier.
s/alot/a lot/
>
> Types are modeled after the linux input layer. There are separate
> event types for each value. There is a sync to indicate the end
> of a event group.
>
> Mouse events are splitted into motion events (one for each axis) and
s/splitted/split/
> button events, which are grouped by sync.
>
> Keyboard events are using the existing KeyValue type.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 76
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
> +
> +##
> +# @InputBtnEvent
Should we spell this out? I'm okay with the abbreviation if it makes it
easier to fit 80 columns, but Button is nicer to read than Btn.
> +
> +##
> +# @InputEvent
> +#
> +# Input event union.
> +#
> +# Since: 2.0
> +##
> +{ 'union' : 'InputEvent',
> + 'data' : { 'key' : 'InputKeyEvent',
> + 'btn' : 'InputBtnEvent',
Again, should we use 'button' instead of 'btn'?
As naming is cosmetic, I can live with what you have.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 09/42] input: add core bits of the new input layer, (continued)
- [Qemu-devel] [PATCH 09/42] input: add core bits of the new input layer, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 23/42] input: mouse: switch gtk ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 05/42] input: rename file to legacy, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 13/42] input: keyboard: switch gtk ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 11/42] input: keyboard: switch legacy handlers to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 25/42] sdl2: switch mouse handling to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 16/42] input: keyboard: switch vnc ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 27/42] input: mouse: switch spice ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 15/42] sdl2: switch keyboard handling to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 06/42] input: qapi: define event types, Gerd Hoffmann, 2014/01/28
- Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types,
Eric Blake <=
- [Qemu-devel] [PATCH 26/42] input: mouse: switch vnc ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 22/42] input: mouse: switch legacy handlers to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 35/42] input-legacy: remove kbd_mouse_event, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 31/42] input: trace events, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 33/42] input-legacy: remove kbd_mouse_has_absolute, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 34/42] input-legacy: remove kbd_mouse_is_absolute, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 40/42] input: move qmp_query_mice to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 36/42] input: move mouse mode notifier to new core, Gerd Hoffmann, 2014/01/28