[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check. |
Date: |
Mon, 3 Feb 2014 10:29:59 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote:
> Building against with a recent glib in a custom prefix fails because
> the gthread cflags in the pkg-config file do not have the correct path
> while the glib pc file does.
>
> Signed-off-by: Chris Johns <address@hidden>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index b472694..12f730f 100755
> --- a/configure
> +++ b/configure
> @@ -2343,9 +2343,9 @@ if test "$mingw32" = yes; then
> else
> glib_req_ver=2.12
> fi
> -if $pkg_config --atleast-version=$glib_req_ver gthread-2.0; then
> - glib_cflags=`$pkg_config --cflags gthread-2.0`
> - glib_libs=`$pkg_config --libs gthread-2.0`
> +if $pkg_config --atleast-version=$glib_req_ver glib-2.0; then
> + glib_cflags=`$pkg_config --cflags glib-2.0`
> + glib_libs=`$pkg_config --libs glib-2.0`
> LIBS="$glib_libs $LIBS"
> libs_qga="$glib_libs $libs_qga"
> else
This change will cause -pthread linker + compiler flag to be lost.
What glib version are you seeing a problem with ? It seems we should
really fix glib, since this will affect countless 1000's of apps using
it, not try to workaround in all downstream apps.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|