Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

[Michael S. Tsirkin]

On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote:
> Michael,
> 
> Am 24.12.2013 18:04, schrieb Andreas Färber:
> > P.S. I reproducibly get a signal message:
> > TEST: tests/acpi-test... (pid=6364)
> >   /i386/acpi/tcg:                                                      
> > main-loop: WARNING: I/O thread spun for 1000 iterations
> > qemu: terminating on signal 15 from pid 6364
> > OK
> > PASS: tests/acpi-test
> > both before and after the queue.
> 
> I'm still seeing this during make check - are you aware? Is there a fix?
> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


so the bug seems to be in the reporting:

static void qemu_kill_report(void)
{
    if (!qtest_enabled() && shutdown_signal != -1) {
        fprintf(stderr, "qemu: terminating on signal %d",
shutdown_signal);
        if (shutdown_pid == 0) {
            /* This happens for eg ^C at the terminal, so it's worth
             * avoiding printing an odd message in that case.
             */
            fputc('\n', stderr);
        } else {
            fprintf(stderr, " from pid " FMT_pid "\n", shutdown_pid);
        }
        shutdown_signal = -1;
    }
}

it shouldn't print this under qtest driver, instead it checks
accelerator value which is wrong.

I just sent a patch, please try it.