[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check success
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response |
Date: |
Thu, 06 Feb 2014 19:09:55 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/06/2014 07:29 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-qmp-commands.c | 44 ++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 36 insertions(+), 8 deletions(-)
>
> diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c
> index 5a3e82a..2416d07 100644
> --- a/tests/test-qmp-commands.c
> +++ b/tests/test-qmp-commands.c
> @@ -71,6 +71,24 @@ static void test_dispatch_cmd_error(void)
> QDECREF(req);
> }
>
> +static QObject *
> +test_qmp_dispatch(QDict *req)
Doesn't qemu style prefer this all on one line?
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/10] qapi: Test coverage & clean up generated code, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/02/06
- Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response,
Eric Blake <=
- [Qemu-devel] [PATCH 03/10] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 05/10] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/06