[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Patch/RFC 16/16] s390x/event-facility: exploit realize/unr
From: |
Christian Borntraeger |
Subject: |
[Qemu-devel] [Patch/RFC 16/16] s390x/event-facility: exploit realize/unrealize |
Date: |
Fri, 7 Feb 2014 18:16:25 +0100 |
From: Heinz Graalfs <address@hidden>
init/exit functionality of abstract SCLPEvent class is now exploiting
realize/unrealize.
Signed-off-by: Heinz Graalfs <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
---
hw/s390x/event-facility.c | 27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
index 5b6d5c6..0777a93 100644
--- a/hw/s390x/event-facility.c
+++ b/hw/s390x/event-facility.c
@@ -377,22 +377,31 @@ static const TypeInfo sclp_event_facility_info = {
.class_size = sizeof(SCLPEventFacilityClass),
};
-static int event_qdev_init(DeviceState *qdev)
+static void event_realize(DeviceState *qdev, Error **errp)
{
- SCLPEvent *event = DO_UPCAST(SCLPEvent, qdev, qdev);
+ SCLPEvent *event = SCLP_EVENT(qdev);
SCLPEventClass *child = SCLP_EVENT_GET_CLASS(event);
- return child->init(event);
+ if (child->init) {
+ int rc = child->init(event);
+ if (rc < 0) {
+ error_setg(errp, "SCLP event initialization failed.");
+ return;
+ }
+ }
}
-static int event_qdev_exit(DeviceState *qdev)
+static void event_unrealize(DeviceState *qdev, Error **errp)
{
- SCLPEvent *event = DO_UPCAST(SCLPEvent, qdev, qdev);
+ SCLPEvent *event = SCLP_EVENT(qdev);
SCLPEventClass *child = SCLP_EVENT_GET_CLASS(event);
if (child->exit) {
- child->exit(event);
+ int rc = child->exit(event);
+ if (rc < 0) {
+ error_setg(errp, "SCLP event exit failed.");
+ return;
+ }
}
- return 0;
}
static void event_class_init(ObjectClass *klass, void *data)
@@ -401,8 +410,8 @@ static void event_class_init(ObjectClass *klass, void *data)
dc->bus_type = TYPE_SCLP_EVENTS_BUS;
dc->unplug = qdev_simple_unplug_cb;
- dc->init = event_qdev_init;
- dc->exit = event_qdev_exit;
+ dc->realize = event_realize;
+ dc->unrealize = event_unrealize;
}
static const TypeInfo sclp_event_type_info = {
--
1.8.4.2
- [Qemu-devel] [Patch/RFC 00/16] s390x/kvm features and fixes, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 05/16] s390x/kvm: Rework SIGP INITIAL CPU RESET handler, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 09/16] s390x/eventfacility: mask out commands, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 02/16] s390x/kvm: implement floating-interrupt controller device, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 04/16] s390x/kvm: Fixed bad SIGP SET-ARCHITECTURE handler, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 03/16] s390x/async_pf: Check for apf extension and enable pfault, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 07/16] s390x/virtio-hcall: Add range check for hypervisor call, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 11/16] s390x/sclp: Add missing checks to SCLP handler, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 15/16] s390x/event-facility: add support for live migration, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 16/16] s390x/event-facility: exploit realize/unrealize,
Christian Borntraeger <=
- [Qemu-devel] [Patch/RFC 14/16] s390x/event-facility: code restructure, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 10/16] s390x/sclp: Fixed the size of sccb and code parameter, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 13/16] s390x/event-facility: some renaming, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 06/16] s390x/kvm: Add missing SIGP CPU RESET order, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 12/16] s390x/sclp: Fixed setting of condition code register, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 08/16] s390x/virtio-hcall: Specification exception for illegal subcodes, Christian Borntraeger, 2014/02/07
- [Qemu-devel] [Patch/RFC 01/16] update linux headers to kvm/next, Christian Borntraeger, 2014/02/07