[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init |
Date: |
Sun, 9 Feb 2014 00:23:19 +0000 |
On 9 February 2014 00:10, Peter Maydell <address@hidden> wrote:
> On 8 February 2014 23:33, Paolo Bonzini <address@hidden> wrote:
>> Il 08/02/2014 18:28, Andreas Färber ha scritto:
>>> Since when is it OK to declare variables in the middle of the block?
>
>> When the code looks better, it is OK since always: checkpatch.pl doesn't
>> complain and -Wdeclaration-after-statement is not added to the compiler
>> flags.
>
> Huh? checkpatch is notoriously not a reliable guide, and we've had
> the "declarations at start of block" rule since forever.
FWIW, we have just 39 files[*] which fail to follow the "declarations at
start of block" rule out of 2566, which is pretty good compliance for a
coding style rule which isn't enforced by technical means (I expect
it's much better than we achieve for "no hard tabs" or "braces on
all if statement arms", for instance).
[*] as tested by a compile with -Wdeclaration-after-statement,
so slightly undercounting but not I think seriously.
thanks
-- PMM
- [Qemu-devel] [PULL 14/16] target-i386: Eliminate CONFIG_KVM #ifdefs, (continued)
- [Qemu-devel] [PULL 14/16] target-i386: Eliminate CONFIG_KVM #ifdefs, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 15/16] target-i386: Don't change x86_def_t struct on cpu_x86_register(), Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 03/16] target-i386: kvm_cpu_fill_host(): No need to check CPU vendor, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 05/16] target-i386: kvm_cpu_fill_host(): Set all feature words at end of function, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 07/16] target-i386: kvm_check_features_against_host(): Kill feature word array, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 12/16] kvm: make hyperv vapic assist page migratable, Paolo Bonzini, 2014/02/03
- [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/03
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Peter Maydell, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/09
- [Qemu-devel] [PATCH] target-i386: Don't declare variables in the middle of blocks, Eduardo Habkost, 2014/02/09
- [Qemu-devel] [qom-cpu PATCH v2] target-i386: Don't declare variables in the middle of blocks, Eduardo Habkost, 2014/02/19
- Re: [Qemu-devel] [qom-cpu PATCH v2] target-i386: Don't declare variables in the middle of blocks, Andreas Färber, 2014/02/20
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Eduardo Habkost, 2014/02/09
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/09
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Peter Maydell, 2014/02/09
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Andreas Färber, 2014/02/08
- Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init, Paolo Bonzini, 2014/02/09
Re: [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03, Peter Maydell, 2014/02/06