[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_star
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct() |
Date: |
Mon, 10 Feb 2014 08:28:29 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/10/2014 07:20 AM, Markus Armbruster wrote:
> Argument is null when visiting an unboxed struct. I can't see such a
> visit in the current code. Fix it anyway.
Is this a sign of missing testsuite coverage?
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qapi/opts-visitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> index 96ed858..5d830a2 100644
> --- a/qapi/opts-visitor.c
> +++ b/qapi/opts-visitor.c
> @@ -124,7 +124,9 @@ opts_start_struct(Visitor *v, void **obj, const char
> *kind,
> OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
> const QemuOpt *opt;
>
> - *obj = g_malloc0(size > 0 ? size : 1);
> + if (obj) {
> + *obj = g_malloc0(size > 0 ? size : 1);
> + }
> if (ov->depth++ > 0) {
> return;
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 08/13] qapi: Fix licensing of scripts, (continued)
- [Qemu-devel] [PATCH v2 10/13] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 02/13] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 06/13] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 05/13] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 07/13] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 03/13] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 11/13] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct(), Markus Armbruster, 2014/02/10
- Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct(),
Eric Blake <=
- [Qemu-devel] [PATCH v2 04/13] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str(), Markus Armbruster, 2014/02/10
- [Qemu-devel] [PATCH v2 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/02/10
- Re: [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code, Paolo Bonzini, 2014/02/13