|
From: | Alex Bennée |
Subject: | Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk |
Date: | Tue, 11 Feb 2014 12:38:33 +0000 |
User-agent: | mu4e 0.9.9.6pre2; emacs 24.3.50.3 |
Dr. David Alan Gilbert <address@hidden> writes: > * Peter Crosthwaite (address@hidden) wrote: >> This was guarding against a full fifo rather than an empty fifo when >> popping. Fix. >> >> Signed-off-by: Peter Crosthwaite <address@hidden> >> --- > > Reviewed-by: Dr. David Alan Gilbert <address@hidden> > > I think this brings it back to how it was on the old FIFO code. This does make me wonder why it was changed? Was there another crashing case it fixed? -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |