[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discrimin
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name |
Date: |
Tue, 11 Feb 2014 06:17:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/10/2014 02:48 PM, Wenchao Xia wrote:
> This series address two issues:
>
> 1. support using enum as discriminator in union.
> For example, if we have following define in qapi schema:
> { 'enum': 'EnumOne',
> 'data': [ 'value1', 'value2', 'value3' ] }
>
> { 'type': 'UserDefBase0',
> 'data': { 'base-string0': 'str', 'base-enum0': 'EnumOne' } }
>
> Before this series, discriminator in union must be a string, and a
> hidden enum type as discriminator is generated. After this series,
> qapi schema can directly use predefined enum type:
> { 'union': 'UserDefEnumDiscriminatorUnion',
> 'base': 'UserDefBase0',
> 'discriminator' : 'base-enum0',
> 'data': { 'value1' : 'UserDefA',
> 'value2' : 'UserDefInherit',
> 'value3' : 'UserDefB' } }
See also:
https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg01663.html
There, I argued that even unions without a 'base':'TypeName' would
benefit from having a discriminator that calls out an enum type listing
the valid branches of the union. I think that could be a followup to
this series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V6 09/10] tests: add cases for inherited struct and union with discriminator, (continued)
[Qemu-devel] [PATCH V6 10/10] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2014/02/11
[Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Wenchao Xia, 2014/02/11
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Markus Armbruster, 2014/02/13
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Wenchao Xia, 2014/02/13
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Markus Armbruster, 2014/02/14
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Wenchao Xia, 2014/02/16
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Markus Armbruster, 2014/02/17
- Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union, Luiz Capitulino, 2014/02/17
Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name,
Eric Blake <=
Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name, Luiz Capitulino, 2014/02/11
Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name, Markus Armbruster, 2014/02/13