[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full. |
Date: |
Tue, 11 Feb 2014 06:20:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/11/2014 12:07 AM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>
> Signed-off-by: Hu Tao <address@hidden>
> ---
> block/qcow2.c | 8 ++++----
> qapi-schema.json | 12 ++++++++++++
> 2 files changed, 16 insertions(+), 4 deletions(-)
> +++ b/qapi-schema.json
> @@ -4419,3 +4419,15 @@
> # Since: 1.7
> ##
> { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
> +
> +##
> +# @PreallocMode
> +#
> +# Preallocation mode of QEMU image file
> +#
> +# @off: no preallocation
> +# @metadata: preallocate only for metadata
> +# @full: preallocate all data, including metadata
Missing a line:
# Since 2.0
> +##
> +{ 'enum': 'PreallocMode',
> + 'data': [ 'off', 'metadata', 'full' ] }
>
With that fixed, you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full, Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full., Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 4/4] qcow2: Add full image preallocation option, Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option, Hu Tao, 2014/02/11
- [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size, Hu Tao, 2014/02/11
- Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full, Stefan Hajnoczi, 2014/02/27