[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature ha
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling |
|
Date: |
Tue, 11 Feb 2014 15:28:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 11.02.2014 10:14, schrieb Eduardo Habkost:
> On Wed, Nov 27, 2013 at 11:28:42PM +0100, Igor Mammedov wrote:
>> features family, model, stepping, level, hv_spinlocks are treated similarly
>> when passed from command line, so it's not necessary to handle each of them
>> individually. Collapse them to one catch-all branch which will treat
>> any not explicitly handled feature in format 'foo=val'.
>>
>> PS:
>> Any unknown feature will be rejected by property setter so there is no
>> need to check for unknown feature in cpu_x86_parse_featurestr(), therefore
>> it's replaced by above mentioned catch-all handler.
>>
>> Signed-off-by: Igor Mammedov <address@hidden>
>
> Reviewed-by: Eduardo Habkost <address@hidden>
Too late:
http://git.qemu.org/?p=qemu.git;a=commit;h=d024d209045b912eb6127861fab2af6c64880efd
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg