qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options
Date: Wed, 12 Feb 2014 16:05:28 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 02/11/2014 11:33 PM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when query

s/query/querying/

> command line options.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -3930,12 +3930,16 @@
>  #
>  # @help: #optional human readable text string, not suitable for parsing.
>  #
> -# Since 1.5
> +# @default: #optional string representation of the default used
> +#           if the option is omitted.
> +#
> +# Since 1.6

Changing the Since line is wrong.  The @default line needs a "(since
2.0)" designation added.

But the schema addition itself is appropriate.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]