[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw b
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css |
Date: |
Thu, 13 Feb 2014 11:04:31 +0000 |
On 13 February 2014 10:05, Christian Borntraeger <address@hidden> wrote:
> On 13/02/14 10:55, Peter Maydell wrote:
>> On 13 February 2014 09:17, Christian Borntraeger <address@hidden> wrote:
>>> static void virtio_setup(uint64_t dev_info)
>>> {
>>> + struct subchannel_id blk_schid = { .one = 1};
>>
>> Missing space before the "}" I think.
>
> checkpatch accepts both ways:
> a) struct subchannel_id blk_schid = { .one = 1};
> b) struct subchannel_id blk_schid = { .one = 1 };
>
> so, change it or keep it?
checkpatch isn't infallible. I think having the space
looks better. In any case you should be consistent
about whether you use a space with both the opening
and the closing brace -- at the moment you've got a
space at one end and not the other.
thanks
-- PMM
[Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx, Christian Borntraeger, 2014/02/13
Re: [Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors, Peter Maydell, 2014/02/13