Re: [Qemu-devel] qemu git does not build on 32bits anymore (incl mingw32)

[Peter Maydell]

On 15 February 2014 17:34, Michael Tokarev <address@hidden> wrote:
> Since this commit:
>
> commit 999b53ec8794f203964db3ecf939a3da5c4bc843
> Author: Claudio Fontana <address@hidden>
> Date:   Wed Feb 5 17:27:28 2014 +0000
>
>     disas: Implement disassembly output for A64
>
>     Use libvixl to implement disassembly output in debug
>     logs for A64, for use with both AArch64 hosts and targets.
>
>     Signed-off-by: Claudio Fontana <address@hidden>
>     [PMM:
>      * added support for target disassembly
>      * switched to custom QEMUDisassembler so the output format
>        matches what QEMU expects
>      * make sure we correctly fall back to "just print hex"
>        if we didn't build the AArch64 disassembler because of
>        lack of a C++ compiler
>      * rename from 'aarch64' to 'arm-a64' because this is a
>        disassembler for the A64 instruction set
>      * merge aarch64.c and aarch64-cxx.cc into one C++ file
>      * simplify the aarch64.c<->aarch64-cxx.cc interface]
>     Signed-off-by: Peter Maydell <address@hidden>
>
> Qemu does not build on mingw32 anymore, with the following error
> messages:
>
>   CXX   disas/libvixl/utils.o
> disas/libvixl/utils.cc:98: error: integer constant is too large for 'unsigned 
> long' type
> disas/libvixl/utils.cc:111: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:111: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:112: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:112: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:113: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:113: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:114: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:114: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:115: error: integer constant is too large for 'long' 
> type
> disas/libvixl/utils.cc:115: error: integer constant is too large for 'long' 
> type
> make: *** [disas/libvixl/utils.o] Error 1
>
> Attached patch fixes this.

Ugh, sorry about that. I thought I'd caught them but obviously the Windows
32 bit build is pickier than the Linux one (it's clearly right though).

PS: your patch has a stray roms/seabios update hunk in it. Other than that
Reviewed-by: Peter Maydell <address@hidden>
and I'll apply it directly shortly since it's a build-breakage.

thanks
-- PMM