Re: [Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX instructions

[Paolo Bonzini]

Il 31/01/2014 15:43, Richard Henderson ha scritto:
> +    gen_shift_maybe_vex:
> +        if (have_bmi2 && !const_args[2]) {
> +            tcg_out_vex_modrm(s, vexop + rexw, args[0], args[2], args[1]);
> +            break;
> +        }
> +        /* FALLTHRU */

What if args[2] happens to be ECX?

Apart from this,

Reviewed-by: Paolo Bonzini <address@hidden>

so feel free to post PATCH 6/5 and then squash it in the pull request.

Paolo