Re: [Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

[Peter Maydell]

On 17 February 2014 10:14, Kevin Wolf <address@hidden> wrote:
> Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben:
>> Commit 1b90d56e changed the implementation of in/out imm to not assign
>> the accessed port number to cpu_T[0] as it appeared unnecessary.
>> However, currently gen_check_io() makes use of cpu_T[0] to implement the
>> I/O bitmap checks, so it's in fact still used and the change broke the
>> check, leading to #GP in legitimate cases (and probably also allowing
>> access to ports that shouldn't be allowed).
>>
>> This patch reintroduces the missing assignment for these cases.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> Reviewed-by: Richard Henderson <address@hidden>
>
> Ping?
>
> /me considers sending a one-patch pull request for an area he's
> absolutely not maintaining, but if this is the only way to get patches
> applied to qemu...

I don't currently have a workflow for identifying and applying
patches which aren't in pull requests (apart from obvious
"fixes build breakage" patches, and even there it's depending
on my happening to notice them). In this case I'd expect rth
to put together a pull request, I guess.

Suggestions for better workflows welcome; we have had issues
with patches falling through the gaps between maintained
subsystems for a long time.

thanks
-- PMM