Re: [Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open()

[Benoît Canet]

The Monday 17 Feb 2014 à 13:42:43 (+0100), Kevin Wolf wrote :
> Am 15.02.2014 um 04:30 hat Max Reitz geschrieben:
> > bdrv_file_open() is now nearly a subset of bdrv_open(), except for the
> > fact that bdrv_file_open() is for protocols and bdrv_open() for block
> > drivers. It is possible to use bdrv_file_open() with a block driver, but
> > in that case that block driver must be explicitly specified.
> > 
> > Due to these great similarities, bdrv_file_open() can be integrated and
> > made a special case of bdrv_open(). If the flag BDRV_O_PROTOCOL is
> > specified, bdrv_open() will now do what bdrv_file_open() used to do:
> > Auto-detecting a protocol instead of a block driver.
> > 
> > This series implements this and changes all calls to bdrv_file_open() to
> > bdrv_open() calls with BDRV_O_PROTOCOL specified.
> > 
> > Note that this flag cannot be discerned automatically since it is
> > impossible for bdrv_open() to know by itself whether a given file should
> > be opened with or without the format layer involved: Both are valid
> > alternatives. Therefore, it still has to be specified by the user.
> 
> This series conflicts with Benoît's patches that have been merged into
> master. When rebasing, please be careful with the code motion patch so
> that you don't accidentally revert Benoît's changes. (It's an easy
> conflict to resolve, but not trivial enough for me to do it while
> applying the patch, with no additional review.)
> 
> Kevin

I will do another review once Max has rebased and resent this series.

Best regards

Benoît

>