[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviou
From: |
Beniamino Galvani |
Subject: |
[Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour |
Date: |
Mon, 17 Feb 2014 18:43:18 +0100 |
According to this mail thread [1], writing to pending register seems
to have no effect on actual pending status of interrupts. This means
that the only way to clear a pending interrupt is to clear the
interrupt source. This patch implements such behaviour.
[1] http://lkml.org/lkml/2013/7/6/59
Signed-off-by: Beniamino Galvani <address@hidden>
---
hw/intc/allwinner-a10-pic.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/intc/allwinner-a10-pic.c b/hw/intc/allwinner-a10-pic.c
index bb2351f..afd57ef 100644
--- a/hw/intc/allwinner-a10-pic.c
+++ b/hw/intc/allwinner-a10-pic.c
@@ -49,6 +49,8 @@ static void aw_a10_pic_set_irq(void *opaque, int irq, int
level)
if (level) {
set_bit(irq % 32, (void *)&s->irq_pending[irq / 32]);
+ } else {
+ clear_bit(irq % 32, (void *)&s->irq_pending[irq / 32]);
}
aw_a10_pic_update(s);
}
@@ -105,10 +107,10 @@ static void aw_a10_pic_write(void *opaque, hwaddr offset,
uint64_t value,
s->nmi = value;
break;
case AW_A10_PIC_IRQ_PENDING ... AW_A10_PIC_IRQ_PENDING + 8:
- s->irq_pending[index] &= ~value;
+ /* Nothing to do */
break;
case AW_A10_PIC_FIQ_PENDING ... AW_A10_PIC_FIQ_PENDING + 8:
- s->fiq_pending[index] &= ~value;
+ /* Ditto */
break;
case AW_A10_PIC_SELECT ... AW_A10_PIC_SELECT + 8:
s->select[index] = value;
--
1.7.10.4
- [Qemu-devel] [PATCH 0/7] Allwinner A10 fixes, Beniamino Galvani, 2014/02/17
- [Qemu-devel] [PATCH 5/7] allwinner-a10-pit: implement prescaler and source selection, Beniamino Galvani, 2014/02/17
- [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour,
Beniamino Galvani <=
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Li Guang, 2014/02/17
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Beniamino Galvani, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Li Guang, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Beniamino Galvani, 2014/02/22
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Li Guang, 2014/02/24
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Beniamino Galvani, 2014/02/24
- Re: [Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour, Li Guang, 2014/02/24
[Qemu-devel] [PATCH 7/7] allwinner-emac: update irq status after writes to interrupt registers, Beniamino Galvani, 2014/02/17
[Qemu-devel] [PATCH 4/7] allwinner-a10-pit: use level triggered interrupts, Beniamino Galvani, 2014/02/17