Re: [Qemu-devel] [PATCH 5/6] target-arm: A64: Implement PMULL instruction

[Richard Henderson]

On 02/16/2014 12:21 PM, Peter Maydell wrote:
> +/* Helper function for 64 bit polynomial multiply case:
> + * perform PolynomialMult(op1, op2) and return either the top or
> + * bottom half of the 128 bit result.
> + */
> +uint64_t HELPER(neon_pmull_64_lo)(CPUARMState *env, uint64_t op1, uint64_t 
> op2)
> +{
> +    int bitnum;
> +    uint64_t res = 0;
> +
> +    for (bitnum = 0; bitnum < 64; bitnum++) {
> +        if (op1 & (1ULL << bitnum)) {
> +            res ^= op2 << bitnum;
> +        }
> +    }
> +    return res;
> +}

These functions don't use env.  Why are you passing it?

r~