[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and c
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access |
Date: |
Tue, 18 Feb 2014 14:11:30 +0100 |
On Tue, 18 Feb 2014 14:08:35 +0100
Cornelia Huck <address@hidden> wrote:
> On Tue, 18 Feb 2014 13:38:54 +0100
> Greg Kurz <address@hidden> wrote:
>
> > From: Rusty Russell <address@hidden>
> >
> > This is based on a simpler patch by Anthony Liguouri, which only handled
> > the vring accesses. We also need some drivers to access these helpers,
> > eg. for data which contains headers.
> >
> > [ ldq_phys() API change, Greg Kurz <address@hidden> ]
> > Signed-off-by: Rusty Russell <address@hidden>
> > Signed-off-by: Greg Kurz <address@hidden>
> > ---
> > hw/virtio/virtio.c | 32 ++++++++++++++++----------------
> > 1 file changed, 16 insertions(+), 16 deletions(-)
> >
>
> > static inline void vring_used_flags_unset_bit(VirtQueue *vq, int mask)
> > {
> > hwaddr pa;
> > pa = vq->vring.used + offsetof(VRingUsed, flags);
> > - stw_phys(&address_space_memory,
> > - pa, lduw_phys(&address_space_memory, pa) & ~mask);
> > + virtio_stw_phys(&address_space_memory,
> > + pa, lduw_phys(&address_space_memory, pa) & ~mask);
> > }
>
> This needs to be virtio_lduw_phys(), no?
Oops yes it should be... my mistake. :)
--
Gregory Kurz address@hidden
address@hidden
Software Engineer @ IBM/Meiosys http://www.ibm.com
Tel +33 (0)562 165 496
"Anarchy is about taking complete responsibility for yourself."
Alan Moore.
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., (continued)
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio., Alexander Graf, 2014/02/18
- [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access, Greg Kurz, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access, Cornelia Huck, 2014/02/18
- Re: [Qemu-devel] [PATCH 2/8] virtio: allow byte swapping for vring and config access,
Greg Kurz <=
- [Qemu-devel] [PATCH 3/8] hw/net/virtio-net: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 4/8] hw/net/virtio-balloon: use virtio wrappers to access page frame numbers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 6/8] hw/scsi/virtio-scsi: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 5/8] hw/block/virtio-blk: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 7/8] hw/char/virtio-serial-bus: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- [Qemu-devel] [PATCH 8/8] hw/9pfs/virtio_9p_device: use virtio wrappers to access headers., Greg Kurz, 2014/02/18
- Re: [Qemu-devel] [PATCH 0/8] virtio endian-ambivalent target fixes (rebased), Andreas Färber, 2014/02/18
Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes., Thomas Huth, 2014/02/14