|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v18 11/14] qapi: make string input visitor parse int list |
Date: | Wed, 19 Feb 2014 09:42:56 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 19/02/2014 09:17, Hu Tao ha scritto:
Two problems: 1. the code is mostly copied from OptsVisitor. maybe we can share the code?
I think it's not a huge problem. Maybe OptsVisitor could be made to use a StringInputVisitor internally.
2. int list is not implemented in string outout visitor. but there is currently no user of it. Should we implement it or not?
Yes, please. We probably will add sooner or later a qom-get/qom-set pair of HMP commands and these will use the string output visitor.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |